[webkit-reviews] review requested: [Bug 73852] Expose reusable WebSocket code for WebSocketServer. : [Attachment 135010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 1 12:22:57 PDT 2012


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 73852: Expose reusable WebSocket code for WebSocketServer.
https://bugs.webkit.org/show_bug.cgi?id=73852

Attachment 135010: Patch
https://bugs.webkit.org/attachment.cgi?id=135010&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Expose maxPayloadLengthWithoutExtendedLengthField as
WebSocketFrame::needsExtendedLengthField to make it consistent with the other
struct helpers. Tell me if that's alright.
WebSocketFrame might also look better as a proper class instead of those
helpers.


More information about the webkit-reviews mailing list