[webkit-reviews] review granted: [Bug 69179] Tops of some <select> elements are clipped with a deviceScaleFactor > 1 : [Attachment 109362] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 17:25:00 PDT 2011


Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 69179: Tops of some <select> elements are clipped with a deviceScaleFactor
> 1
https://bugs.webkit.org/show_bug.cgi?id=69179

Attachment 109362: Patch
https://bugs.webkit.org/attachment.cgi?id=109362&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109362&action=review


> Source/WebCore/rendering/RenderThemeMac.mm:786
> +	   inflatedRect = inflateRect(inflatedRect, size, popupButtonMargins(),
zoomLevel * WebCore::deviceScaleFactor(o->frame()));

Do you really need the WebCore:: prefix?


More information about the webkit-reviews mailing list