[webkit-reviews] review granted: [Bug 69050] Fix assertion failure in XSS Auditor : [Attachment 109361] Patch

Fri Sep 30 15:58:29 PDT 2011

Daniel Bates <dbates at webkit.org> has granted Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 69050: Fix assertion failure in XSS Auditor
https://bugs.webkit.org/show_bug.cgi?id=69050

Attachment 109361: Patch
https://bugs.webkit.org/attachment.cgi?id=109361&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109361&action=review

Thanks for taking the time to add a test case that works.

> LayoutTests/fast/forms/xss-auditor-doesnt-crash.html:1
> +<html>

Nit: We should add the HTML5 doctype, <!DOCTYPE html>, since this page doesn't
need quirks mode.

> LayoutTests/fast/forms/xss-auditor-doesnt-crash.html:3
> +    <script src="../js/resources/js-test-pre.js"></script>

As far as I can tell we don't use any functionality that is provided by this
external script. Please remove it.