[webkit-reviews] review granted: [Bug 68572] Create unit tests for LayerChromium : [Attachment 108896] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 68572: Create unit tests for LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68572

Attachment 108896: Patch
https://bugs.webkit.org/attachment.cgi?id=108896&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108896&action=review


R=me. To upload a new patch to fix the nits and request commit, but without
requiring a new review, replaced 'Reviewed by NOBODY (OOPS!).' in the ChangeLog
with 'Reviewed by James Robinson.' and do:

webkit-patch upload --no-review --request-commit

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:56
> +    LayerChromiumWithInstrumentedDestructor(CCLayerDelegate* delegate)

nit: explicit keyword on 1-arg constructors, please.

c++ got the default wrong for this behavior - i think you should have to say
'implicit' to get implicit type conversion behavior. it's super annoying :(

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:262
> +    // The child delegate notifySynRequired should not be called when
inserting.

typo: notifySynRequired->notifySyncRequired