[webkit-reviews] review granted: [Bug 69166] Inset focus ring (Skia on Mac) : [Attachment 109338] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 13:43:27 PDT 2011


Stephen White <senorblanco at chromium.org> has granted Cary Clark
<caryclark at google.com>'s request for review:
Bug 69166: Inset focus ring (Skia on Mac)
https://bugs.webkit.org/show_bug.cgi?id=69166

Attachment 109338: Patch
https://bugs.webkit.org/attachment.cgi?id=109338&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109338&action=review


The constants seem a little mysterious (although no more mysterious than they
were before).  A comment would be nice.  r=me

> Source/WebCore/ChangeLog:13
> +	   No new tests. This platform is not enabled.

Nit:  It would be nice to know which tests will exercise this when the platform
is enabled (if any).


More information about the webkit-reviews mailing list