[webkit-reviews] review requested: [Bug 48544] support -webkit-tap-highlight-color : [Attachment 109337] patch v3 to fix reported broken tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 30 13:21:50 PDT 2011
Johnny(Jianning) Ding <jnd at chromium.org> has asked for review:
Bug 48544: support -webkit-tap-highlight-color
https://bugs.webkit.org/show_bug.cgi?id=48544
Attachment 109337: patch v3 to fix reported broken tests
https://bugs.webkit.org/attachment.cgi?id=109337&action=review
------- Additional Comments from Johnny(Jianning) Ding <jnd at chromium.org>
This patch fixed the tests broken on try bot reported in comment #28. After
considering the features support difference among all webkit ports (they may
Change in the future) and "-webkit-tap-highlight-color" only supported on ports
which support TOUCH_EVENTS. I disable the "-webkit-tap-highlight-color" output
on related get computed style tests and only test it by using the new layout
test fast/events/touch/tap-highlight-color.html.
Kenneth, Antonio, would you like to reexamine it? Thanks!
More information about the webkit-reviews
mailing list