[webkit-reviews] review granted: [Bug 35273] fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed : [Attachment 109321] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 12:21:22 PDT 2011


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 35273: fast/forms/text-control-intrinsic-widths.html fails on Mac if
Word/Office fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=35273

Attachment 109321: Patch
https://bugs.webkit.org/attachment.cgi?id=109321&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=109321&action=review


> Tools/DumpRenderTree/mac/DumpRenderTree.mm:224
> +static NSSet* allowedFontFamilySet()

The space should go before the star.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:226
> +    static NSSet* fontFamiliySet = [[NSSet setWithObjects:

Ditto.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:347
> +

One blank line is enough.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:372
> +	   NSArray* fontsForFamily = [[NSFontManager sharedFontManager]
availableMembersOfFontFamily:fontFamily];

The space should go before  the start.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:373
> +	   for (NSArray* fontInfo in fontsForFamily) {

The space should go before the star.

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:34
> +static NSSet* allowedFontFamilySet()

The space should go before the star.

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:36
> +    static NSSet* fontFamiliySet = [[NSSet setWithObjects:

Ditto.

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:157
> +

One blank line is enough.

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:182
> +	   NSArray* fontsForFamily = [[NSFontManager sharedFontManager]
availableMembersOfFontFamily:fontFamily];

The space should go before the star.

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:183
> +	   for (NSArray* fontInfo in fontsForFamily) {

Ditto.


More information about the webkit-reviews mailing list