[webkit-reviews] review granted: [Bug 69154] feBlend uses a table of function pointers which reduces inlineability inside the main loop : [Attachment 109312] style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 30 10:51:22 PDT 2011


Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 69154: feBlend uses a table of function pointers which reduces
inlineability inside the main loop
https://bugs.webkit.org/show_bug.cgi?id=69154

Attachment 109312: style
https://bugs.webkit.org/attachment.cgi?id=109312&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Putting the switch inside the loop speeds things up by 20%. Could you speed up
even more by putting the switch outside the loop? With template functions you
could even inline the functions and have the switch statement outside the
entire apply function. How much more would that speed things up?


More information about the webkit-reviews mailing list