[webkit-reviews] review denied: [Bug 69061] [EFL] Only set when the custom encoding is different from existing value : [Attachment 109221] Patch

[bugzilla-daemon at webkit.org]

Leandro Pereira <leandro at profusion.mobi> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 69061: [EFL] Only set when the custom encoding is different from existing
value
https://bugs.webkit.org/show_bug.cgi?id=69061

Attachment 109221: Patch
https://bugs.webkit.org/attachment.cgi?id=109221&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=109221&action=review


> Source/WebKit/efl/ChangeLog:10
> +	   ewk_view_setting_encoding_custom_set() has set a new custom encoding
value, reloading
> +	   the page even when not needed. This patch sets the custom encoding
only when new value
> +	   differ.

Sorry to nitpick, but I think something along the lines of "Only set the custom
encoding value if it is different from the current value, to avoid reloading
the page." would be more clear.