[webkit-reviews] review denied: [Bug 56466] Popup menu can get stuck in closed state when GtkMenu can't grab mouse. : [Attachment 109276] proposed patch to fix this issue in recent revision

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Wajahat Siddiqui
<mdwajahatali.siddiqui at motorola.com>'s request for review:
Bug 56466: Popup menu can get stuck in closed state when GtkMenu can't grab
mouse.
https://bugs.webkit.org/show_bug.cgi?id=56466

Attachment 109276: proposed patch to fix this issue in recent revision
https://bugs.webkit.org/attachment.cgi?id=109276&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109276&action=review


> Source/WebCore/platform/gtk/PopupMenuGtk.cpp:95
> +    // GTK can refuse to actually open the menu when mouse grabs fails.
> +    // Ensure WebCore does not go into some pesky state.
> +    if (!gtk_widget_get_visible(m_popup->platformMenu()))
> +	   client()->popupDidHide();

You shold also include this fix in
Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp.