[webkit-reviews] review canceled: [Bug 66664] [Qt][WK2] Add the animations on the ViewportInteractionEngine : [Attachment 109166] proposed patch

[bugzilla-daemon at webkit.org]

Andras Becsi <abecsi at webkit.org> has canceled Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 66664: [Qt][WK2] Add the animations on the ViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=66664

Attachment 109166: proposed patch
https://bugs.webkit.org/attachment.cgi?id=109166&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
(In reply to comment #14)
> Andras, can we look at this together next week? Kenneth just explained to me
the idea of animating between points instead of animating the geometries. We
should try to re-use some code from Grob here.

Sure. I just uploaded the patch to get feedback. Although git diff made the
patch hard to understand, I agree.

I basically use the geometry for position correction so the kinetic "pan throw
animation", which's intensity is proportional with scale and gesture trajectory
does not overshoot. This position correction needs the geometry, which is
"dirty" when a zoom animation is ongoing, so I pass the requested geometry
basically for position correction.
But using the content position in the center of the viewport for animations
should be a more practical approach, if I understand Kenneth's idea correctly.