[webkit-reviews] review granted: [Bug 69117] [chromium] Add WebKit API for sending input events to the compositor thread : [Attachment 109240] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 69117: [chromium] Add WebKit API for sending input events to the compositor
thread
https://bugs.webkit.org/show_bug.cgi?id=69117

Attachment 109240: Patch
https://bugs.webkit.org/attachment.cgi?id=109240&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109240&action=review


> Source/WebKit/chromium/public/WebCompositor.h:53
> +#endif // WebCompositor_h

ditto

> Source/WebKit/chromium/public/WebCompositorClient.h:43
> +#endif // WebCompositorClient_h

style-nit: I mistyped this... the style guide suggests putting a comment on the
close
of the namespace, not on the #endif.  i just mixed that up when i was typing
this file
earlier.  the other headers in WebKit/chromium/public/ do it that way.

>> Source/WebKit/chromium/tests/CCThreadTest.cpp:32
>> +#include "CCThreadImpl.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Perhaps this is saying that "CC" sorts before "cc"??