[webkit-reviews] review granted: [Bug 68975] watchlist: Add cross-checks for WatchList once it is filled. : [Attachment 109212] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 68975: watchlist: Add cross-checks for WatchList once it is filled.
https://bugs.webkit.org/show_bug.cgi?id=68975

Attachment 109212: Patch
https://bugs.webkit.org/attachment.cgi?id=109212&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109212&action=review


I'm not sure I 100% follow, but I'm willing to rubber-stamp this.

> Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:111
> +		   raise Exception('A rule for definition "%s" is empty, so it
should be deleted.' % complex_definition)

I wonder if you want your own Exception subclass.