[webkit-reviews] review denied: [Bug 69121] run-api-tests fails on chromium-win bot : [Attachment 109244] patch (fixed a grammar error in help message)

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 69121: run-api-tests fails on chromium-win bot
https://bugs.webkit.org/show_bug.cgi?id=69121

Attachment 109244: patch (fixed a grammar error in help message)
https://bugs.webkit.org/attachment.cgi?id=109244&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109244&action=review


> Tools/Scripts/run-api-tests:68
> +  --[no-]build	   Build (or do not build) unit tests prior to running
(default: $buildDefault. No use for Chromium as buile-webkit builds everything)


Not used for Chromium because build-webkit builds everything

Actually, I'd skip this part of the change.

> Tools/Scripts/run-api-tests:85
> -buildTestTool() if $build;
> +buildTestTool() if $build && !isChromium();

I'd also skip this part.

> Tools/Scripts/run-api-tests:285
> -    my $buildProcess = open3($childIn, $childOut, $childErr,
$pathToBuildTestTool, @args) or die "Failed to run " . $buildTestTool;
> +    my $buildProcess = open3($childIn, $childOut, $childErr, "perl",
$pathToBuildTestTool, @args) or die "Failed to run " . $buildTestTool;

This is the only part that's needed.

Are you sure you don't need to put $pathToBuildTestTool into @args?  I'm
somewhat of a Perl novice.  :)