[webkit-reviews] review denied: [Bug 67740] Fixed Hit testing on Framesets when Frameset is transformed : [Attachment 109215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 29 18:08:00 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 67740: Fixed Hit testing on Framesets when Frameset is transformed
https://bugs.webkit.org/show_bug.cgi?id=67740

Attachment 109215: Patch
https://bugs.webkit.org/attachment.cgi?id=109215&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109215&action=review


Code changes look ok, but r- for one more test.

> LayoutTests/fast/frames/frame-set-scaling-hit.html:15
> +	   function init() {
> +	       if (!window.eventSender)
> +		   return;
> +	       var leftPanelWidth = window.innerWidth / 8;
> +	       eventSender.scalePageBy(0.5, 0, 0);
> +	       eventSender.mouseMoveTo(leftPanelWidth, window.innerHeight / 4);

> +	       eventSender.mouseDown();
> +	       eventSender.mouseMoveTo(2 * leftPanelWidth, window.innerHeight /
4);
> +	       eventSender.mouseUp();
> +	   }

Please add a comment to say that this is trying to resize the frames. It wasn't
obvious.

I'd like to see a test that has a rotation too.


More information about the webkit-reviews mailing list