[webkit-reviews] review denied: [Bug 68321] [EFL] Use C++ type cast instead of C style type cast : [Attachment 109226] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 68321: [EFL] Use C++ type cast instead of C style type cast
https://bugs.webkit.org/show_bug.cgi?id=68321

Attachment 109226: Patch
https://bugs.webkit.org/attachment.cgi?id=109226&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109226&action=review


> Source/WebKit/efl/ewk/ewk_view.cpp:929
> +	   px = static_cast<double>((x + cx) / (w + sd->view.w));

Casting the entire expression here is semantically identical to the implicit
cast. You need to at least cast the first operand of the division.