[webkit-reviews] review granted: [Bug 69100] Add logic to collect dirty objects as roots : [Attachment 109213] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 69100: Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100

Attachment 109213: Patch
https://bugs.webkit.org/attachment.cgi?id=109213&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109213&action=review


r=me

> Source/JavaScriptCore/ChangeLog:39
> +	      Tidy the write barrier a bit.

"I rearranged the order of these instructions because it makes them smaller on
some platforms with some card sizes".

> Source/JavaScriptCore/heap/AllocationSpace.cpp:171
> +    GatherDirtyCells(MarkedBlock::DirtyCellVector*);

I award you zero points, and may god have mercy on your soul.