[webkit-reviews] review granted: [Bug 69099] [Freetype] Some text in Planet GNOME renders in the wrong place : [Attachment 109189] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 69099: [Freetype] Some text in Planet GNOME renders in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=69099

Attachment 109189: Patch
https://bugs.webkit.org/attachment.cgi?id=109189&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109189&action=review


Just one comment to the test.

> LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html:26
> +This test verifies that the CTM does not cause text that has
> +a synthetic oblique to render in the wrong part of the page.
> +You should be able to see three separate block characters below
> +and the middle should be rendered in italic.

To be honest, I don't think that it makes sense to use Ahem on the one side,
but print the description on the screen as well. Would it be enough to insert
it as a HTML comment?