[webkit-reviews] review granted: [Bug 48544] support -webkit-tap-highlight-color : [Attachment 109113] patch v3 to make ews happy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 29 12:05:27 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Johnny(Jianning)
Ding <jnd at chromium.org>'s request for review:
Bug 48544: support -webkit-tap-highlight-color
https://bugs.webkit.org/show_bug.cgi?id=48544

Attachment 109113: patch v3 to make ews happy
https://bugs.webkit.org/attachment.cgi?id=109113&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109113&action=review


r=me, as noone complained about the feature on the ML and it is used by iOS,
Playbook, Nokia N9 series and possible others as well. It can thus be
considered a widely used WebKit mobile/touch feature.

> Source/WebCore/rendering/style/StyleRareInheritedData.h:80
> -    unsigned userSelect : 1;  // EUserSelect
> +    unsigned userSelect : 1; // EUserSelect

Let's remove unrelated changes


More information about the webkit-reviews mailing list