[webkit-reviews] review granted: [Bug 69023] Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand : [Attachment 109066] Patch

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 69023: Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in
ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=69023

Attachment 109066: Patch
https://bugs.webkit.org/attachment.cgi?id=109066&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109066&action=review


Looks good to me.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1226
> +	   }

I know the original code was already like this, but it would be nice to have
methods to update m_firstNodeInserted and m_lastLeafInserted in a consistent
way. It is a bit unclear when reading this code that, in the case of the
trailing space there is no explicit update of m_lastLeafInserted, but there is
an explicit updated of m_firstNodeInserted in case of the leading space. Only
reading the comment above helps you understand.