[webkit-reviews] review requested: [Bug 27238] Animated GIF dynamically removed and readded to page does not re-animate : [Attachment 109010] Fix for GIF not animating on dynamic detach & attach - revision 2

[bugzilla-daemon at webkit.org]

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27238: Animated GIF dynamically removed and readded to page does not
re-animate
https://bugs.webkit.org/show_bug.cgi?id=27238

Attachment 109010: Fix for GIF not animating on dynamic detach & attach -
revision 2
https://bugs.webkit.org/attachment.cgi?id=109010&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
(In reply to comment #23)
> (From update of attachment 109010 [details])
> I suspect this can trigger network reload of the image if the element is
re-added to the document (in case it is expired, has no-store, etc). I don't
see why bug about restarting animation needs a change with such a broad
potential side effects.

Actually I think this is precisely the correct behavior.  When the image is
removed from the document, it should really be removed; any caches should not
still hang onto it.  If when re-added later that means we have to redownload it
that's perfectly fine.

I think you should rethink your opposition to this patch.