[webkit-reviews] review denied: [Bug 69015] Web Inspector: Add support for backend search in script content. : [Attachment 109156] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 69015: Web Inspector: Add support for backend search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015

Attachment 109156: Patch
https://bugs.webkit.org/attachment.cgi?id=109156&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109156&action=review


> LayoutTests/http/tests/inspector/search/search-in-concatenated-script.html:10

> +    InspectorTest._runAfterResourcesAreCreated(["search-concatenated.html"],
step2);

You should wait for resource loading to finish.

> LayoutTests/http/tests/inspector/search/search-in-script.html:10
> +    InspectorTest._runAfterResourcesAreCreated(["search.js"], step2);

ditto

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:326
> +    String content = m_scripts.get(scriptId).source;

You should look it up first.