[webkit-reviews] review denied: [Bug 69061] [EFL] Only set when the custom encoding is different from existing value : [Attachment 109124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 29 06:18:51 PDT 2011


Leandro Pereira <leandro at profusion.mobi> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 69061: [EFL] Only set when the custom encoding is different from existing
value
https://bugs.webkit.org/show_bug.cgi?id=69061

Attachment 109124: Patch
https://bugs.webkit.org/attachment.cgi?id=109124&action=review

------- Additional Comments from Leandro Pereira <leandro at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=109124&action=review


Although this check could be made inside the embedder, it is harmless enough to
be inside EWK. The change looks fine, just a minor nit in the ChangeLog entry.

> Source/WebKit/efl/ChangeLog:10
> +	   ewk_view_setting_encoding_custom_set() has set a new custom encoding
unconditionally
> +	   despite new custom encoding is same with existing value. This patch
sets only new
> +	   custom encoding when new custom encoding value is different from
existing value.

ewk_view_setting_encoding_custom_set() sets a new custom ... value, reloading
the page even when not needed. This patch sets the custom encoding only when
the new value differs from the current value.


More information about the webkit-reviews mailing list