[webkit-reviews] review denied: [Bug 69058] Explicitly wrap DFG operations with FunctionPtr when being called in JSVALUE32_64 DFG JIT : [Attachment 109118] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 69058: Explicitly wrap DFG operations with FunctionPtr when being called in
JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058

Attachment 109118: the patch
https://bugs.webkit.org/attachment.cgi?id=109118&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Looks like this patch is pre r96293, is there still a problem post-r96293?
I don't think we want to take this change.  We should be able to give
FunctionPtr an appropriate set of constructors.
If Linux defaults to stdcall, it is possible that the '#if CPU(X86) &&
COMPILER(GCC)' check in  DFGOperations.h should be '#if
CALLING_CONVENTION_IS_CDECL'.
We should be able to fix the problem without littering the JIT with explicit
constructor calls.