[webkit-reviews] review granted: [Bug 69054] JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor : [Attachment 109110] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 28 23:46:42 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 69054: JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to
incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054

Attachment 109110: proposed patch
https://bugs.webkit.org/attachment.cgi?id=109110&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Maybe we should just do away with this constructor - could be worth examining
it's uses, I think in many cases the arguments might make more sense as
size_t's (e.g. subscripts to arrays in CodeBlock).  But seems sensible for now.


More information about the webkit-reviews mailing list