[webkit-reviews] review granted: [Bug 69010] Web Inspector: network log view refresh optimizations : [Attachment 109038] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 69010: Web Inspector: network log view refresh optimizations
https://bugs.webkit.org/show_bug.cgi?id=69010

Attachment 109038: patch
https://bugs.webkit.org/attachment.cgi?id=109038&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109038&action=review


> Source/WebCore/inspector/front-end/NetworkPanel.js:678
> +		   node.element.addStyleClass("offscreen");

You should move this to where the element is accessible after creation:
WebInspector.NetworkDataGridNode.prototype.createCells in your case.

> Source/WebCore/inspector/front-end/NetworkPanel.js:702
> +	   // FIXME: evaluate performance impact of moving this before a call
to sortItems()

Would be great to address it in this change. Note that while populating the log
from scratch, wasScrolledToLastRow is always true. It might be that it is a
noop though.