[webkit-reviews] review denied: [Bug 67114] [EFL] API to get plain text of the frame : [Attachment 107859] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 67114: [EFL] API to get plain text of the frame
https://bugs.webkit.org/show_bug.cgi?id=67114

Attachment 107859: Patch
https://bugs.webkit.org/attachment.cgi?id=107859&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107859&action=review


> Source/WebKit/efl/ewk/ewk_frame.cpp:1590
> +char* ewk_frame_plain_text_get(const Evas_Object* o)

Please don't use one-letter variable.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1596
> +    if (sd->frame->view() && sd->frame->view()->layoutPending())
> +	   sd->frame->view()->layout();

innerText automatically calls updateLayoutIgnorePendingStylesheets.

> Source/WebKit/efl/ewk/ewk_frame.cpp:1598
> +    WebCore::Element* documentElement =
sd->frame->document()->documentElement();

I don't think we should assume that the frame has a document.