[webkit-reviews] review granted: [Bug 69046] DFG JIT Operations on 32_64 should use stdcall calling convention. : [Attachment 109106] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 69046: DFG JIT Operations on 32_64 should use stdcall calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69046

Attachment 109106: Fix
https://bugs.webkit.org/attachment.cgi?id=109106&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109106&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:59
> +// Defined on X86 platforms if stdcall is not the standard!
> +#define STDCALL_NOT_STANDARD __attribute__ ((stdcall))

How about we replace the second standard with default.	This should probably be
in Compiler.h.

> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1319
> +#if !PLATFORM(MAC)

Please give this #define a more clear explanation.