[webkit-reviews] review granted: [Bug 69040] ScrollbarThemeComposite requires a ScrollView to draw scroll corner : [Attachment 109095] proposed fix

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 69040: ScrollbarThemeComposite requires a ScrollView to draw scroll corner
https://bugs.webkit.org/show_bug.cgi?id=69040

Attachment 109095: proposed fix
https://bugs.webkit.org/attachment.cgi?id=109095&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109095&action=review


> Source/WebCore/platform/qt/ScrollbarThemeQt.cpp:248
> +    // FIXME: It's incorrect to do invalidation while painting.
>      if (context->updatingControlTints()) {
>	  scrollView->invalidateRect(rect);

It's actually OK during the "updatingControlTints" paint phase. This is a
special paint whose sole purpose is to invalidate things whose appearance
changes based on the window's activation state.