[webkit-reviews] review granted: [Bug 68828] DelayNode must set the context on delayTime AudioParam to support automation : [Attachment 109082] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 68828: DelayNode must set the context on delayTime AudioParam to support
automation
https://bugs.webkit.org/show_bug.cgi?id=68828

Attachment 109082: Patch
https://bugs.webkit.org/attachment.cgi?id=109082&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109082&action=review


Looks good. Minor cleanup in the tests is still desired but feel free to do
this upon landing the patch. r=me

> LayoutTests/webaudio/delaynode-scheduling.html:18
> +var context;

This doesn't need to be here.

> LayoutTests/webaudio/delaynode-scheduling.html:29
> +    context = new webkitAudioContext(1, sampleRate * renderLengthSeconds,
sampleRate);

You can just use "var context" here.

> LayoutTests/webaudio/delaynode.html:18
>  var context;

Same change here -- no global variable needed.

> LayoutTests/webaudio/delaynode.html:29
>      context = new webkitAudioContext(1, sampleRate * renderLengthSeconds,
sampleRate);

Can use local variable declaration here too.