[webkit-reviews] review denied: [Bug 68959] Extend DOM WheelEvent to differentiate between physical and logical scroll directions : [Attachment 109079] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jon Lee <jonlee at apple.com>'s request for
review:
Bug 68959: Extend DOM WheelEvent to differentiate between physical and logical
scroll directions
https://bugs.webkit.org/show_bug.cgi?id=68959

Attachment 109079: Patch
https://bugs.webkit.org/attachment.cgi?id=109079&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109079&action=review


I think we probably want to prefix the IDL attribute with webkit as well.

> Source/WebCore/platform/mac/WheelEventMac.mm:104
> +    , m_directionInvertedFromDevice([event isDirectionInvertedFromDevice])

I think this probably needs to be conditional on Lion or later.