[webkit-reviews] review requested: [Bug 62887] JavaScript access to text tracks from HTMLMediaElement : [Attachment 109074] changing unsigned short conversion in CodeGeneratorGObject.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 28 14:06:45 PDT 2011


Anna Cavender <annacc at chromium.org> has asked  for review:
Bug 62887: JavaScript access to text tracks from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=62887

Attachment 109074: changing unsigned short conversion in
CodeGeneratorGObject.pm
https://bugs.webkit.org/attachment.cgi?id=109074&action=review

------- Additional Comments from Anna Cavender <annacc at chromium.org>
Perhaps a better solution is to not allow CodeGeneratorGObject.pm to generate
the non-existent g_value_get_ushort() function.  I've changed it to instead
generate g_value_get_uint(), which does exist, when it sees the type 'unsigned
short'.  I think this is a ligit change because it already converts 'short' to
'g_value_get_int()', so converting unsigned short to uint seems reasonable.


More information about the webkit-reviews mailing list