[webkit-reviews] review denied: [Bug 13332] List marker not displayed on items with overflow : [Attachment 109040] Include marker rectangle into clip.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 28 13:10:29 PDT 2011


Dave Hyatt <hyatt at apple.com> has denied Konstantin Shcheglov
<scheglov at google.com>'s request for review:
Bug 13332: List marker not displayed on items with overflow
https://bugs.webkit.org/show_bug.cgi?id=13332

Attachment 109040: Include marker rectangle into clip.
https://bugs.webkit.org/attachment.cgi?id=109040&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This is pretty obviously wrong. You only patched the non-layer case, and you
have to handle both cases. In addition doing a unite will cause content that
might have spilled out of the overflow:hidden box to become visible.

Any approach that solves this problem has to allow the marker to paint while
still preserving an accurate clip for everything else. One idea might be to
paint markers at the same time as your own background/shadows etc. so that the
overflow clip won't have been pushed yet.


More information about the webkit-reviews mailing list