[webkit-reviews] review granted: [Bug 66890] [GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore : [Attachment 107454] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 28 09:54:13 PDT 2011


Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 66890: [GTK] Move drag-and-drop code which can be shared with WebKit2 to
WebCore
https://bugs.webkit.org/show_bug.cgi?id=66890

Attachment 107454: Patch
https://bugs.webkit.org/attachment.cgi?id=107454&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107454&action=review


Nice and clean refactoring! Just a little nit to fix in the ChangeLog before
landing. Thanks!

> Source/WebCore/ChangeLog:16
> +	   * GNUmakefile.list.am: Added the GtkWidgetDragAndDropGlue to the
sources list.
> +	   * platform/gtk/GtkWidgetDragAndDropGlue.cpp: Added.
> +	   * platform/gtk/GtkWidgetDragAndDropGlue.h: Added.

Was this the first name of GtkDragAndDropHelper?


More information about the webkit-reviews mailing list