[webkit-reviews] review granted: [Bug 68936] [Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules : [Attachment 109024] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 68936: [Chromium] Seperate GTK specific Gyp rules from X11 Gyp rules
https://bugs.webkit.org/show_bug.cgi?id=68936

Attachment 109024: Patch
https://bugs.webkit.org/attachment.cgi?id=109024&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109024&action=review


> Source/WebCore/WebCore.gyp/WebCore.gyp:1642
> +	   ['use_x11 == 0', {
> +	     'sources/': [
> +	       ['exclude', 'Linux\\.cpp$'],

It might be more accurate to do 'os_posix and OS!="mac"', but this is OK too.