[webkit-reviews] review denied: [Bug 65361] background color affects the font color in disabled textarea : [Attachment 109005] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 65361: background color affects the font color in disabled textarea
https://bugs.webkit.org/show_bug.cgi?id=65361

Attachment 109005: proposed patch
https://bugs.webkit.org/attachment.cgi?id=109005&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109005&action=review


Checking specifically for the Color::transparent value is not right. The right
way to check that something is transparent is to check its alpha channel only,
not to explicitly check for a particular RGB as well as alpha. We could have a
minimum alpha value. It's a good insight, though, that difference from white is
meaningless for a transparent or mostly transparent color.

To refine the rule, I’m not sure if simply using lightening unconditionally is
the right way to handle a transparent or translucent background color. It seems
we’d want to figure out the likely color from behind the text to have a good
chance of getting the behavior right.

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

Bug fixes need to come with test cases. That includes this one.