[webkit-reviews] review granted: [Bug 66936] [GStreamer] fullscreen video pause/play fails : [Attachment 105342] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 66936: [GStreamer] fullscreen video pause/play fails
https://bugs.webkit.org/show_bug.cgi?id=66936

Attachment 105342: proposed patch
https://bugs.webkit.org/attachment.cgi?id=105342&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=105342&action=review


This looks sane to me.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:377
>  GstElement*
> -webkit_video_sink_new(void)
> +webkit_video_sink_new(WebCore::GStreamerGWorld* gstGWorld)

This should be one line.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:379
> +    GstElement* element = (GstElement*)g_object_new(WEBKIT_TYPE_VIDEO_SINK,
0);

Please use a C++-style cast or if GST_ELMENT is available, use that.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:381
> +    WebKitVideoSink* sink = WEBKIT_VIDEO_SINK(element);
> +    sink->priv->gstGWorld = gstGWorld;

This should be one line.