[webkit-reviews] review denied: [Bug 68996] [GTK][WEBKIT2] Add Font and Encoding properties to WebKitWebSettings. : [Attachment 109023] Added Font and Encoding related API's

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 68996: [GTK][WEBKIT2] Add Font and Encoding properties to
WebKitWebSettings.
https://bugs.webkit.org/show_bug.cgi?id=68996

Attachment 109023: Added Font and Encoding related API's
https://bugs.webkit.org/attachment.cgi?id=109023&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109023&action=review


>> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:54
>> +	gchar* defaultEncoding;
> 
> Use GOwnPtr<char> for these.

I recommend using CString instead.

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:305
>> +
> 
> We don't need this either.

If he uses GOwnptr or CString he does.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:1225
> +    WKStringRef standardFontFamilyRef =
WKStringCreateWithUTF8CString(defaultFontFamily);
> +    WKPreferencesSetStandardFontFamily(priv->preferences,
standardFontFamilyRef);
> +    priv->defaultFontFamily = static_cast<gchar *>
(g_realloc(priv->defaultFontFamily, WKStringGetLength(standardFontFamilyRef) +
1));
> +    WKStringGetUTF8CString(standardFontFamilyRef, priv->defaultFontFamily,
WKStringGetLength(standardFontFamilyRef) + 1);
> +    WKRelease(standardFontFamilyRef);
> +

Is it important to refetch the font name from WebKit?