[webkit-reviews] review granted: [Bug 68998] Web Inspector: Add support for search in single resource to page agent. : [Attachment 109015] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 68998: Web Inspector: Add support for search in single resource to page
agent.
https://bugs.webkit.org/show_bug.cgi?id=68998

Attachment 109015: Patch
https://bugs.webkit.org/attachment.cgi?id=109015&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109015&action=review


> Source/WebCore/inspector/Inspector.json:110
> +		       { "name": "line", "type": "string", "description": "Line
with match." }

"name": "lineText" or "name": "lineContent"

> Source/WebCore/inspector/InspectorPageAgent.cpp:487
> +static PassRefPtr<InspectorObject> buildObjectForSearchMatch(int lineNumber,
String line)

Consider moving to ContentSearchUtil

> Source/WebCore/inspector/InspectorPageAgent.cpp:522
> +    RegularExpression regex = ContentSearchUtils::createSearchRegex(text,
false, false);

This all could belong to the utility method.