[webkit-reviews] review granted: [Bug 66496] [GTK] textInputController.doCommand is not implemented : [Attachment 109003] Patch

[bugzilla-daemon at webkit.org]

Chang Shu <cshu at webkit.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 66496: [GTK] textInputController.doCommand is not implemented
https://bugs.webkit.org/show_bug.cgi?id=66496

Attachment 109003: Patch
https://bugs.webkit.org/attachment.cgi?id=109003&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109003&action=review


Actually, I plan to modify the password echo tests to use eventSender, if
possible, instead of textInputController.doCommand so they can be widely
accepted. But it's nice to have this supported on GTK anyway. thanks.

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601
> +    return;

this return can be removed.

> LayoutTests/ChangeLog:3
> +	   Removed skipped tests under textInputController.doCommand for Gtk
Port.

I usually still put the title here and some brief comments below.

> LayoutTests/platform/gtk/Skipped:-1548
> -

It's surprising but true that doCommand is used only in the above tests and
some mac-specific tests. :)