[webkit-reviews] review granted: [Bug 68986] Web Inspector: UI performance test for Inspector start-up time is required : [Attachment 108988] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 68986: Web Inspector: UI performance test for Inspector start-up time is
required
https://bugs.webkit.org/show_bug.cgi?id=68986

Attachment 108988: Patch
https://bugs.webkit.org/attachment.cgi?id=108988&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108988&action=review


> LayoutTests/inspector/performance/resources/inspector-startup-time.html:20
> +    if (new Date() - testStartTime > 20000) {

new Date() -> Date.now()

> LayoutTests/inspector/performance/resources/inspector-startup-time.html:25
> +    layoutTestController.closeWebInspector();

Would be nice to wait until the inspector has closed before starting next
performance test.