[webkit-reviews] review granted: [Bug 68930] Web Inspector: Refactor searching in inspector, add test (+fix). : [Attachment 108906] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 28 00:49:09 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 68930: Web Inspector: Refactor searching in inspector, add test (+fix).
https://bugs.webkit.org/show_bug.cgi?id=68930
Attachment 108906: Patch
https://bugs.webkit.org/attachment.cgi?id=108906&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108906&action=review
> LayoutTests/ChangeLog:3
> + Web Inspector: Refactor searching in inspector, add test (+fix).
What is (+fix) in the title? Also the log entry should contain a description of
the changes made.
> Source/WebCore/inspector/ContentSearchUtils.h:44
> + ContentSearchUtils() { }
You may use a namespace instead.
More information about the webkit-reviews
mailing list