[webkit-reviews] review granted: [Bug 68968] Only resolve direction aware properties when properties are direction aware. : [Attachment 108957] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 68968: Only resolve direction aware properties when properties are
direction aware.
https://bugs.webkit.org/show_bug.cgi?id=68968

Attachment 108957: Patch
https://bugs.webkit.org/attachment.cgi?id=108957&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108957&action=review


This seems reasonable to make directional properties slower at the cost of
making all other properties faster.

> Source/WebCore/css/CSSStyleSelector.cpp:3635
> +	   return applyProperty(CSSProperty::resolveDirectionAwareProperty(id,
m_style->direction(), m_style->writingMode()), value);

Are we sure we're calling this with the right arguments?