[webkit-reviews] review requested: [Bug 62887] JavaScript access to text tracks from HTMLMediaElement : [Attachment 108958] changing TextTrack::mode from unsigned short to unsigned int

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 27 21:15:46 PDT 2011


Anna Cavender <annacc at chromium.org> has asked  for review:
Bug 62887: JavaScript access to text tracks from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=62887

Attachment 108958: changing TextTrack::mode from unsigned short to unsigned int
https://bugs.webkit.org/attachment.cgi?id=108958&action=review

------- Additional Comments from Anna Cavender <annacc at chromium.org>
For some reason, when the gtk build auto generates WebKitDOMTextTrack.cpp, it
uses g_value_get_ushort() for the mode property.  As far as I can tell,
g_value_get_ushort doesn't exist in <glib-object.h> or any other current
resource I could find. So, I have changed 'mode' to be an unsigned int instead
of an unsigned short.  I am unsure if this is an appropriate solution, please
advise.


More information about the webkit-reviews mailing list