[webkit-reviews] review denied: [Bug 66032] Allow site authors to override autofilled fields' colors. : [Attachment 103579] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 66032: Allow site authors to override autofilled fields' colors.
https://bugs.webkit.org/show_bug.cgi?id=66032

Attachment 103579: Patch
https://bugs.webkit.org/attachment.cgi?id=103579&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
(In reply to comment #9)
> (In reply to comment #8)
> > Dear Apple folks, please add your thoughts in response to comment #6. Or
should I just move forward on this issue by making this a Chromium-only change?

> 
> Since Maciej is the one who said those things, I think he should probably be
the one to reply.
> 
> I don’t think the security issue is really all that strong, but Maciej is far
more savvy than I about such things.

I don't think the security issue is that serious either. I just gave my opinion
when asked.

I *do* think the issue of making sure we have a supportable standards-track API
for this, if we are going to expose the capability to Web content authors,
instead of exposing a random piece of engine internals. I don't think that
concern has been addressed. The right working group to contact would be the CSS
Working Group. It would be easy to get at least informal input on www-style on
whether an autofill pseudoclass is the right way to go).

I don't think making this a Chromium-only change would remove our
responsibility to make a supportable, standards-track design. Since people
apparently want me to turn my offhanded remarks into a decision of some sort, I
guess I have to mark this patch r- based on what I said above. I would also r-
a version of the patch that did the same thing with Chromium ifdefs if the
above concern was not addressed (in fact, even more so since it would be
gratuitously forking Web platform behavior).