[webkit-reviews] review granted: [Bug 34222] http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot : [Attachment 108918] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 27 16:53:18 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 34222: http/tests/navigation/anchor-basic.html is flaky on Snow Leopard
Release Bot
https://bugs.webkit.org/show_bug.cgi?id=34222
Attachment 108918: Patch
https://bugs.webkit.org/attachment.cgi?id=108918&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108918&action=review
> LayoutTests/ChangeLog:10
> + Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without
> + it, the img onload handler doesn't always run. Also reduce the
> + multipart timeout (should help to unblock other http requests).
Could you re-format the comment so that it doesn't use double-space? Also it
seems awkward for "it" to appear at the beginning of a line or "the" to appear
at the end of a line.
More information about the webkit-reviews
mailing list