[webkit-reviews] review canceled: [Bug 68939] Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent : [Attachment 108916] Simplified the function with additional fixes and refactoring
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 27 16:07:18 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 68939: Simplify ReplaceSelectionCommand::positionAtStartOfInsertedContent
https://bugs.webkit.org/show_bug.cgi?id=68939
Attachment 108916: Simplified the function with additional fixes and
refactoring
https://bugs.webkit.org/attachment.cgi?id=108916&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108916&action=review
> Source/WebCore/rendering/RenderText.cpp:1606
> -unsigned RenderText::caretMaxRenderedOffset() const
> +unsigned RenderText::renderedTextLength() const
Come to think of it, caretMaxOffset should call this function. Will do in a
minute.
More information about the webkit-reviews
mailing list