[webkit-reviews] review denied: [Bug 67684] [Chromium/FileWriter] race condition in FileWriter completion can lead to assert : [Attachment 108884] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Eric U. <ericu at chromium.org>'s
request for review:
Bug 67684: [Chromium/FileWriter] race condition in FileWriter completion can
lead to assert
https://bugs.webkit.org/show_bug.cgi?id=67684

Attachment 108884: Patch
https://bugs.webkit.org/attachment.cgi?id=108884&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108884&action=review


r- because I know you are doing one more revision (regarding the code
rearrangement thing we discussed in email).

There are a few things below that might be nice to address but it looks good.

> LayoutTests/fast/filesystem/resources/file-writer-abort-continue.js:23
> +    onwriteend : checkLengthAndCallFollowOnAction

Thanks. I find it much easier to figure out what this test is doing now!

I personally think this FollowOnAction makes the code harder to read for very
minimal gain but it is ok to leave it as is....

> LayoutTests/fast/filesystem/resources/file-writer-abort-continue.js:47
> +    onwriteend : onWriteEnd3

"onWriteEnd3" vestige of the old unreadable code? :)