[webkit-reviews] review granted: [Bug 67700] REGRESSION(65665): Pattern size being clamped to SVG size can prevent transformed elements from being fully covered by userSpaceOnUse patterns : [Attachment 108886] new patch, correctly scaling oversized patterns to fit (down to fit in the tile, up to fit on the screen)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 67700: REGRESSION(65665): Pattern size being clamped to SVG size can
prevent transformed elements from being fully covered by userSpaceOnUse
patterns
https://bugs.webkit.org/show_bug.cgi?id=67700

Attachment 108886: new patch, correctly scaling oversized patterns to fit (down
to fit in the tile, up to fit on the screen)
https://bugs.webkit.org/attachment.cgi?id=108886&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108886&action=review


> Source/WebCore/rendering/svg/SVGImageBufferTools.cpp:31
> +static float kMaxImageBufferSize = 4096.0;

Nitpick: This should just be 4096 (an int) rather than 4096.0 (a double).
Neither is a float, but that's OK.