[webkit-reviews] review granted: [Bug 68922] Paginated floats should not grow the height of a block when they don't end up being tied to a line. : [Attachment 108877] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 68922: Paginated floats should not grow the height of a block when they
don't end up being tied to a line.
https://bugs.webkit.org/show_bug.cgi?id=68922

Attachment 108877: Patch
https://bugs.webkit.org/attachment.cgi?id=108877&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=108877&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2696
> +	   lineInfo.setFloatPaginationStrut(lineInfo.floatPaginationStrut() +
paginationStrut);

I am surprised, without looking at the rest of the code, that the right thing
to do here is to add, not to max(). It would be nice to have a test case with
two floats that exercises this.